5 votes Vote

Add RTL button support (CSS rule > direction:rtl;)

Add a new button to the toolbar, which enable RTL support
it has to insert a CSS role of direction:rtl; around the focused paragraph

nadavkav , 01.12.2011, 17:18
Idea status: completed

Comments

johnyma22, 01.12.2011, 17:23
RTL should also apply to other objects.

I opened an issue here for this: https://github.com/Pita/etherpad-lite/issues/256

Ideally we would detect if the browser is set to RTL and apply based on that, adding a button to the toolbar is a bodge fix. I will put a temporary fix in that will allow you to pass a parameter for RTL. This will take a few hours to do.

Can you sign up for github please and test it when I publish a fix?
nadavkav, 01.12.2011, 19:40
Hi Johny :-)

I do not think we should trust the browser. since i am not sure most of the users know that they can set their preferred language with the browser. plus, i we better leave this decision in the hand of the users.

A RTL / LTR button is very easy to develop. i suppose.
It's good enough to let the user switch manually to the writing direction he/she prefers. i think.

Just to make sure we are talking on the same thing, i am referring to CSS direction:rtl; and direction:ltr; for the entire example:
Some RTL text in Arabic or Hebrew
And not justifing of text to right or left : text-align:right; or text-align:left;
johnyma22, 01.12.2011, 21:50
Hi nadavkav, as this is very easy to develop, I will leave this to you, you can contribute the patch when you are done here: http://github.com/Pita/etherpad-lite/
nadavkav, 01.12.2011, 21:54
Great. I will :-)
johnyma22, 01.12.2011, 21:57
FYI it has to be a parameter AND/OR some sort of locality detection., not a button. I can't add a button to the UI for < ~3% of our users.
johnyma22, 01.12.2011, 21:57
FYI it has to be a parameter AND/OR some sort of locality detection., not a button. I can't add a button to the UI for < ~3% of our users.
nadavkav, 01.12.2011, 22:02
OK :-)
johnyma22, 04.12.2011, 19:27
Mheh, I did this:
https://github.com/Pita/etherpad-lite/pull/271

I also made a video tutorial: http://www.youtube.com/watch?v=MDMrLRDJL_I&feature=youtu.be
johnyma22, 04.12.2011, 19:27
Mheh, I did this:
https://github.com/Pita/etherpad-lite/pull/271

I also made a video tutorial: http://www.youtube.com/watch?v=MDMrLRDJL_I&feature=youtu.be
nadavkav, 04.12.2011, 19:52
Thank you Johny!

That is a great video and an excellent new feature.

Lucky me, i was so busy with other coding that i did not have the time to even look or dig into this, Since it would have taken me much more time then it took you to solve this.
( I know, now )

Again, thanks!
johnyma22, 04.12.2011, 19:53
No worries, will put it live in the next x days/weeks, gotta get merged into master and tested first.
johnyma22, 14.12.2011, 21:08
Append ?trl=true to the end of your Pad URL For example:

http://willyou.typewith.me/p/KZdgzjaT5V?rtl=true
nadavkav, 14.12.2011, 21:22
Beautiful! Thank you :-)
Mallamzulka, 29.07.2013, 09:24
Could you write about Phcyiss so I can pass Science class?
Irina, 31.07.2013, 11:40
None can doubt the verctiay of this article.

Leave a comment